[
https://issues.apache.org/jira/browse/IO-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483570#comment-13483570
]
David Bild commented on IO-349:
-------------------------------
Thanks much for the code review and commit.
FYI, the tests for the existing #writeByteArrayToFile methods use the platform
default charset for String encoding. Is there a reason to prefer UTF-8 (those
were the only modifications I saw in the unit tests)? If so, I can submit a
patch to update the existing tests as well.
> Add API with array offset and length argument to
> FileUtils.writeByteArrayToFile
> -------------------------------------------------------------------------------
>
> Key: IO-349
> URL: https://issues.apache.org/jira/browse/IO-349
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.4
> Reporter: David Bild
> Labels: patch
> Fix For: 2.5
>
> Attachments:
> add_OffsetAndLengthArguments_To_FileUtils_writeByteArrayToFile.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The FileUtils.writeByteArrayToFile method does not allow a subset of an array
> to be written to a file. Instead, the subset must be copied to a separate
> array, increasing the lines of code and (for all JVMs I know about) runtime.
> Sister methods that take an offset and length should be added, inline with
> the byte array-oriented methods in the Java standard library.
> Attached is a patch that implements FileUtils.writeByteArrayToFile(File file,
> byte[] data, int offset, int length) and FileUtils.writeByteArrayToFile(File
> file, byte[] data, int offset, int length, boolean append) and associated
> testcases in FileUtilsTestCase.java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
