[
https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485138#comment-13485138
]
Thomas Neidhart commented on CODEC-161:
---------------------------------------
Hi Colm,
thanks for your contribution, I looked at the patch and it's not so bad, though
it will require some adaptations before it can be accepted:
* indentation is normally 4 chars, only spaces
* author name is usually omitted in the source files, but added to the pom.xml
* try to avoid trailing spaces in a line
* naming convention for methods: camel case, e.g. removeVowels, instead of
RemoveVowels
* try to use parenthesis also for single line if clauses
* documentation for private methods should be using javadoc style or omitted
* the removeAccents method uses indexOf in a string to remove accents, but
this can be rather slow for large strings
better use a set of all accent chars
btw. there is a checkstyle configuration in the trunk, which you can use to
check your contribution (e.g. with the eclipse plugin or on the command line
with maven: mvn checkstyle:checkstyle). The less warnings remain the more
likely it is that a patch will be committed ;-).
Thomas
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons
> codec.
> What I have at the moment is a class called
> org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing
> StringEncoder
> I have a pretty comprehensive test file located at:
> org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here.
> Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received
> some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
