[
https://issues.apache.org/jira/browse/MATH-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles updated MATH-887:
------------------------
Attachment: MATH-887.diff
A first patch for this issue.
Note that it makes a unit test fail ("testMath199") because the weight matrix
is not positive definite. With the proposed code, it seems that the problem
posed by this input is detected earlier (and fails differently than expected by
the unit test).
Is it OK to change the expected exception?
> "AbstractLeastSquares" cleanup
> -------------------------------
>
> Key: MATH-887
> URL: https://issues.apache.org/jira/browse/MATH-887
> Project: Commons Math
> Issue Type: Task
> Affects Versions: 3.0
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.1, 4.0
>
> Attachments: MATH-887.diff
>
>
> Class "AbstractLeastSquares" (in package "o.a.c.m.optimization.general") has
> a lot of "protected" fields that are modified by its subclasses (e.g.
> "LevenbergMarquardt"). This decreases encapsulation which in turn makes the
> code more difficult to understand and modify.
> I propose to deprecate (in 3.1) and remove or make "private" (in 4.0) all
> fields that could be hidden or should be modified through setter methods.
> Part of the code could also be more readable (and self-documenting) by making
> use of higher-level constructs such as "RealMatrix" rather than using
> explicit loops.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
