[
https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491585#comment-13491585
]
Sebb commented on LANG-757:
---------------------------
If the method is made private, then there is no need to check the assumption
(provided it is documented).
I would turn the question around:
Where does the OWASP document say that trailing semi-colons are ignored for
anything other than hex-encoded and long utf-8 entities?
> StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon
> ---------------------------------------------------------------------
>
> Key: LANG-757
> URL: https://issues.apache.org/jira/browse/LANG-757
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
> Affects Versions: 2.x
> Reporter: Steve Hale
> Priority: Minor
> Attachments: commons-lang3-LANG-757.patch
>
>
> org.apache.commons.lang.StringEscapeUtils.unescapeHtml is useful in detecting
> and correcting Cross-Site Scripting (XSS) attempts by converting escaped
> chars like &# 60; or & lt; (remove spaces) into normal chars like < so
> patterns like HTML tags can be detected. Many browsers will allow variations
> without semicolons, particularly the long UTF-8 encoding like <.
> Please see: http://ha.ckers.org/xss.html
> Since this may not be standard HTML, maybe adding a boolean bLenient
> parameter to the method could allow better backward compatibility.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
