[ 
https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502705#comment-13502705
 ] 

Martin Rust commented on CODEC-163:
-----------------------------------


Am 22.11.2012 um 11:34 schrieb Sebb (JIRA):


   [ 
https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502699#comment-13502699
 ]

Sebb commented on CODEC-163:
----------------------------

BTW, if you provide further patches to JIRA, please name them .patch or .txt 
(e.g. CODEC-163.patch) as that allows JIRA to display them as text to browsers. 
Otherwise one has to download the file in order to open it in a text editor. 
Thanks.


OK, thanks, I will.

I followed the advice on http://commons.apache.org/patches.html, so you might 
consider mentioning this fact there ;) ;)

Martin



ColognePhonetic encoder unneccessarily creates lots of char arrays on every 
loop run
------------------------------------------------------------------------------------

               Key: CODEC-163
               URL: https://issues.apache.org/jira/browse/CODEC-163
           Project: Commons Codec
        Issue Type: Improvement
          Reporter: Martin Rust
          Priority: Minor
            Labels: performance
       Attachments: patch-CODEC-163


The summary says it all.
I've created a patch and have attached it.
I've benchmarked a 10% performance improvement. Admittedly, I expected more, 
but other positive effects should be less strain on heap and GC.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


                
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every 
> loop run
> ------------------------------------------------------------------------------------
>
>                 Key: CODEC-163
>                 URL: https://issues.apache.org/jira/browse/CODEC-163
>             Project: Commons Codec
>          Issue Type: Improvement
>            Reporter: Martin Rust
>            Priority: Minor
>              Labels: performance
>         Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, 
> but other positive effects should be less strain on heap and GC.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to