[
https://issues.apache.org/jira/browse/COMPRESS-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540850#comment-13540850
]
Stefan Bodewig commented on COMPRESS-211:
-----------------------------------------
Don't hesitate, we are a commit-then-review community and this is just SCM
anyway, things can be modified/fixed/reverted later.
I'd prefer the fields in X7875_NewUnix to be private (and I guess checkstyle
agrees with me, you may want to run a site build and watch the checkstyle, PMD
and findbugs reports). NewUnixExtraField would be more in line with the other
class names, but I'm not good at name at all and don't have any problem with
your choice.
Wouldn't it make more sense to return BigIntegers in getUID/GID since they
could be created from more than 63bits (I assume uids are unsigned)?
I find your usage of new BigDecimal(1000).toBigIntegerExact() a bit curious (so
far I've used BigInteger#valueOf) - is there a special reason behind it?
I tend to use JUnit4 for completely new test classes, YMMV.
The static helper methods might be candidates for ZipUtil.
> handle zip extra field 0x7875 - Info Zip New Unix Extra Field
> -------------------------------------------------------------
>
> Key: COMPRESS-211
> URL: https://issues.apache.org/jira/browse/COMPRESS-211
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Reporter: Julius Davies
> Assignee: Julius Davies
> Priority: Minor
> Attachments: compress-211.patch
>
>
> From Info Zip (zip-3.0)'s source archive (proginfo/extrafld.txt):
> {code}
> -Info-ZIP New Unix Extra Field:
> ====================================
> Currently stores Unix UIDs/GIDs up to 32 bits.
> (Last Revision 20080509)
> Value Size Description
> ----- ---- -----------
> (UnixN) 0x7875 Short tag for this extra block type ("ux")
> TSize Short total data size for this block
> Version 1 byte version of this extra field, currently 1
> UIDSize 1 byte Size of UID field
> UID Variable UID for this entry
> GIDSize 1 byte Size of GID field
> GID Variable GID for this entry
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
