[
https://issues.apache.org/jira/browse/CONFIGURATION-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557620#comment-13557620
]
Oliver Heger commented on CONFIGURATION-521:
--------------------------------------------
Hi, many thanks for the updated patch. I think this is the way to go. Some
minor comments:
* I would rather keep the old method name. We are currently working on a major
relase, and thus we could introduce changes breaking backwards compatibility,
but we should do so only for a compelling reason. Staying as compatible as
possible will make migration for clients smoother.
* Would it be possible to also provide a unit test demonstrating that the
original problem is fixed now?
* Commons Configuration obviously uses a slightly different coding style than
IO. Can you adapt the formatting to the style used in this project? (This is
not strictly necessary, I can also do the reformat if needed.)
> fileFromUrl: decoding of encoded % character does not work
> ----------------------------------------------------------
>
> Key: CONFIGURATION-521
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-521
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 1.9
> Reporter: Oliver Kopp
> Attachments: fileFromUrl.patch, update-to-FileUtils-rev1349509.patch
>
>
> If ConfigurationUtils.fileFromUrl(URL) should create a file from a URL
> containing an enoced % sign (%25), then it does not work.
> I saw that the code apache.commons.io now is really different, but seems to
> work. Why isn't apache.commons.io directly used?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
