[ 
https://issues.apache.org/jira/browse/LOGGING-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583415#comment-13583415
 ] 

Thomas Neidhart commented on LOGGING-144:
-----------------------------------------

Thanks for the pointer, this looks cleaner compared to my patch.

Although, if I understand it correctly, this will also throw additional 
unchecked exceptions (ThreadDeath & VirtualMachineError) that where swallowed 
and logged before?
                
> LogFactory/LogFactoryImpl ingore Throwable
> ------------------------------------------
>
>                 Key: LOGGING-144
>                 URL: https://issues.apache.org/jira/browse/LOGGING-144
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>         Attachments: LOGGING-144.patch
>
>
> The code in LogFactory/LogFactoryImpl catches and ignores Throwable in 
> several places.
> This is a bad idea, as some Throwables (e.g. ThreadDeath) should never be 
> ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to