[
https://issues.apache.org/jira/browse/DBCP-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598823#comment-13598823
]
Steve Westwood commented on DBCP-392:
-------------------------------------
Agreed - the layout for these methods is inconsistent with others in the class,
it does make debugging awkward plus clarity is lost. The issue I believe
applies to the following methods:
* public void clearWarnings() throws SQLException
* public void commit() throws SQLException
* public String getCatalog() throws SQLException
* public int getTransactionIsolation() throws SQLException
* public Map<String,Class<?>> getTypeMap() throws SQLException
* public SQLWarning getWarnings() throws SQLException
* public String nativeSQL(String sql) throws SQLException
* public void rollback() throws SQLException
* public void setTransactionIsolation(int level) throws SQLException
* public void setTypeMap(Map<String,Class<?>> map) throws SQLException
* public int getHoldability() throws SQLException
* public void setHoldability(int holdability) throws SQLException
* public java.sql.Savepoint setSavepoint() throws SQLException
* public java.sql.Savepoint setSavepoint(String name) throws SQLException
* public void rollback(java.sql.Savepoint savepoint) throws SQLException
* public void releaseSavepoint(java.sql.Savepoint savepoint) throws SQLException
> Remove Occurrences of Multiple Statements on One Line
> -----------------------------------------------------
>
> Key: DBCP-392
> URL: https://issues.apache.org/jira/browse/DBCP-392
> Project: Commons Dbcp
> Issue Type: Improvement
> Affects Versions: 1.4
> Reporter: James Carman
> Priority: Minor
>
> The DelegatingConnection class has many methods that are one-liners, but it's
> actually multiple statements. When debugging, it can make it appear as if
> the code is being executed twice (it did to me) at first glance. If it's
> multiple statements, we should use multiple lines of code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
