[ 
https://issues.apache.org/jira/browse/MATH-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601567#comment-13601567
 ] 

Andrew Waterman commented on MATH-460:
--------------------------------------

Hi Luc,

My apologies for not updating you guys sooner. I haven't touched the code for 
about 6 months; I got hung up on implementing the standard distribution tests.

My last commit includes the re-incorporating the work from the 2010 patch along 
with the work I did in conjunction with my mathematician friend, Jim Smith, 
here in Chiapas. 

The main issue is really how to test the implementation. 

Please see my GitHub commit for more details:

https://github.com/awaterma/commons-math/commit/a2396a824352dc372a5e8c58409be6d21150b071

The following methods in the Class I'm unsure about:

public boolean isSupportLowerBoundInclusive() {
+        return false;  //To change body of implemented methods use File | 
Settings | File Templates.
+    }
+
+    public boolean isSupportUpperBoundInclusive() {
+        return false;  //To change body of implemented methods use File | 
Settings | File Templates.
+    }
+
+    public boolean isSupportConnected() {
+        return false;  //To change body of implemented methods use File | 
Settings | File Templates.
+    }

And, as you can see from my local commit, the tests are incomplete. I had 
planned on finishing this but got caught up with other projects. At least my 
changes have incorporated much of Pavel's work in the "new" inheritance model 
and the skeleton for the correct unit test is available. As I mentioned above, 
I had quite a few problems with the rmutil package for helping build out these 
tests (it's not available in a normal R repository). Do you have any other 
suggestions/implementations that might speed this along? It would be nice to 
submit something to you guys after so many comment threads.
                
> Levy Distribution
> -----------------
>
>                 Key: MATH-460
>                 URL: https://issues.apache.org/jira/browse/MATH-460
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Pavel Ryzhov
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: levy_math_460.patch
>
>
> Pretty straightforward implementation of Levy Distribution (not Levy 
> alpha-stable) according to http://en.wikipedia.org/wiki/Lévy_distribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to