[
https://issues.apache.org/jira/browse/COLLECTIONS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601616#comment-13601616
]
Oliver Heger commented on COLLECTIONS-325:
------------------------------------------
+1, the class does not really fit into Collections.
Commons Configurations should provide various alternatives (however, improving
thread-safety is a topic here, too.)
> Improve thread-safety of ExtendedProperties
> -------------------------------------------
>
> Key: COLLECTIONS-325
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-325
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Sebb
>
> It looks as though ExtendedProperties is intended to be thread-safe,
> otherwise why bother synchronizing load() and save()?
> If so, then ExtendedProperties field "isInitialized" should be made volatile
> to ensure the variable is correctly published.
> Likewise, the field "includePropertyName" needs to be volatile or
> synchronised.
> Also, the following protected variables could be made final to improve
> thread-safety:
> defaults
> file
> basePath
> fileSeparator - this could perhaps be static too?
> keysAsListed
> Regardless of thread-safety issues, does it make sense for these variables to
> be changed once initialised?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
