Sebb created DBUTILS-109:
----------------------------
Summary: AbstractExecutor.currentPosition should be an int
Key: DBUTILS-109
URL: https://issues.apache.org/jira/browse/DBUTILS-109
Project: Commons DbUtils
Issue Type: Bug
Reporter: Sebb
AbstractExecutor.currentPosition is currently an Integer.
It is only used here:
posList.add(++currentPosition);
This involves converting the Integer to an int, incrementing the int and then
converting back to an Integer.
It would be rather more efficient to create the field as an int.
Alternatively, if the class is supposed to be thread-safe, maybe an
AtomicInteger would be better.
Integer is not the best choice here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
