[ 
https://issues.apache.org/jira/browse/MATH-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608325#comment-13608325
 ] 

Thomas Neidhart commented on MATH-862:
--------------------------------------

The RealMatrix interface has 3 methods that have a double[][] as parameters:

 * copySubMatrix(int, int, int, int, double[][])
 * copySubMatrix(int[], int[], double[][])
 * setSubMatrix(double[][], int, int)

The setSubMatrix in AbstractRealMatrix and Array2DRowRealMatrix already have a 
check for a rectangular matrix.

In r1459081 the check + unit tests have also been added to the copySubMatrix 
methods.
                
> AbstractRealMatrix should check that all supplied double[][] arrays are 
> rectangular
> -----------------------------------------------------------------------------------
>
>                 Key: MATH-862
>                 URL: https://issues.apache.org/jira/browse/MATH-862
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Sébastien Brisard
>            Priority: Minor
>              Labels: exception, linear
>
> Many methods in RealMatrix take as an argument a {{double[][]}} as the 
> representation of a matrix. As such, the array should be rectangular. Checks 
> should be provided, as requested in the Javadoc of e.g. {{void 
> setSubMatrix(double[][], int, int)}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to