[ 
https://issues.apache.org/jira/browse/MATH-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608721#comment-13608721
 ] 

Thomas Neidhart edited comment on MATH-862 at 3/21/13 7:33 AM:
---------------------------------------------------------------

My fix was wrong for copySubMatrix, as the javadoc states that the provided 
array does not have to be strictly the size of the submatrix to be copied. The 
check should take this into account and only verify that there is enough space 
for the copy operation.
                
      was (Author: tn):
    My fix was wrong for copySubMatrix, as the javadoc states that the provided 
array does not have to be strictly the size of the submatrix to be copied. The 
check should take this into account and only verify that there is enough place 
for the copy operation.
                  
> AbstractRealMatrix should check that all supplied double[][] arrays are 
> rectangular
> -----------------------------------------------------------------------------------
>
>                 Key: MATH-862
>                 URL: https://issues.apache.org/jira/browse/MATH-862
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Sébastien Brisard
>            Priority: Minor
>              Labels: exception, linear
>             Fix For: 3.2
>
>
> Many methods in RealMatrix take as an argument a {{double[][]}} as the 
> representation of a matrix. As such, the array should be rectangular. Checks 
> should be provided, as requested in the Javadoc of e.g. {{void 
> setSubMatrix(double[][], int, int)}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to