[ 
https://issues.apache.org/jira/browse/CONFIGURATION-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609289#comment-13609289
 ] 

Yanlin Ye commented on CONFIGURATION-535:
-----------------------------------------

Thanks for your quick response.

Yes, the close() method is for convenient purpose.  If you are moving away from 
the direct DB connections/statements, I guess it will no longer be necessary.

The reason I had asked for its exposure is that I copied several methods from 
the original implementation to apply my desired changes.  I had to copy the 
close() method as well :(

By the way, thanks a lot for the great work on apache projects!  I've used some 
libraries and programs and all worked great.

If my extension to the DatabaseConfiguration is of any value to others, I am 
more than happy to provide the source.
                
> Add getters for the initial parameters of DatabaseConfiguration
> ---------------------------------------------------------------
>
>                 Key: CONFIGURATION-535
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-535
>             Project: Commons Configuration
>          Issue Type: Wish
>            Reporter: Yanlin Ye
>            Priority: Trivial
>              Labels: features
>
> We use database configuration to support a centralized location for 
> configuration properties common to some distributed components of our 
> application, and it works great.  In order for our application components to 
> report issues (especially when we have database connection issues), we 
> extended database configuration to maintain a backup cache for all properties 
> and update the cache whenever a property is accessed.  This way, the cached 
> properties can be used if the properties cannot be loaded from the database.  
> The extension works as expected and can report issues even if the database 
> connection becomes not available.
> The only (minor) thing is that, when we extended DatabaseConfiguration, we 
> had to maintain another copy of the initial parameters such as table name, 
> name/key/value columns, etc, because DatabaseConfiguration does not provide 
> access to them.  I was wondering whether or not the following can be added to 
> DatabaseConfiguration to make it easier to be extended.
> - Add getters for initialization parameters, and
> - Change private void close(Connection, Statement) to protected for reuse.
> Please ignore if you don't think the suggested changes can be useful to users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to