[ 
https://issues.apache.org/jira/browse/MATH-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611765#comment-13611765
 ] 

Luc Maisonobe commented on MATH-917:
------------------------------------

I like this design very much. It is clear, simple and the separation between 
distance and point is really an interesting feature.

The only remarks I have concern the naming of the Clusterable interface 
methods. Wouldn't it be easier to understand if dataSize were renamed dimension 
and value were renamed element or component?

The javadoc for DoublePoint is wrong, it mentions integer coordinates rather 
than double coordinates.

+1 to add this and deprecate the whole stat.clustering package.
                
> More distance measurements are needed in o.a.c.m.stat.clustering.
> -----------------------------------------------------------------
>
>                 Key: MATH-917
>                 URL: https://issues.apache.org/jira/browse/MATH-917
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Reid Hochstedler
>             Fix For: 4.0
>
>         Attachments: clustering.zip
>
>
> Currently only Euclidean distance is used for distance measurement, it would 
> be easy to quickly add Manhattan and Chebyshev distance among others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to