[
https://issues.apache.org/jira/browse/IO-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652095#comment-13652095
]
Claudio Nieder commented on IO-380:
-----------------------------------
I think the behaviour of copyFile Sebb mentions is better because if you get
passed an open stream, it shouldn't be your business to close it. But that's a
design decision of commons-io, how it wants to handle passed streams. So as
long as the behaviour is properly documented, it is fine for me.
Thanks for fixing this so quickly!
> FileUtils.copyInputStreamToFile should document it closes the input source
> --------------------------------------------------------------------------
>
> Key: IO-380
> URL: https://issues.apache.org/jira/browse/IO-380
> Project: Commons IO
> Issue Type: Improvement
> Affects Versions: 2.4
> Environment: JDK 7, OSX 10.8.3 (doesn't matter)
> Reporter: Claudio Nieder
> Priority: Trivial
> Fix For: 2.5
>
>
> It would be nice to extend the parameter description
> @param source the <code>InputStream</code> to copy bytes from, must not be
> {@code null}
> to read:
> @param source the <code>InputStream</code> to copy bytes from, must not be
> {@code null}, will be closed
> so that one is aware it cannot be used e.g. on ZipInputStream which require
> the stream to still be open for executing zip.getNextEntry.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
