[
https://issues.apache.org/jira/browse/COLLECTIONS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb reopened COLLECTIONS-455:
------------------------------
I think the fields should at least be made package protected where possible.
It's misleading to expose the fields as protected if they are not intended to
be mutable by sub-classes (and may make subsequent changes more difficult)
Where the fields cannot be made package protected, I suggest adding a
getter/setter which is documented as being for internal use only.
> AbstractDualBidiMap<K, V> has several mutable protected fields
> --------------------------------------------------------------
>
> Key: COLLECTIONS-455
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-455
> Project: Commons Collections
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 4.0
>
>
> Any non-private mutable fields make it much harder to ensure thread-safety as
> well as making it very difficult to test thoroughly.
> The fields should be made private.
> If protected write access really is needed, setter methods should be used.
> These methods can take any necessary precautions to ensure thread-safety.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
