[
https://issues.apache.org/jira/browse/CHAIN-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692317#comment-13692317
]
Benedikt Ritter commented on CHAIN-98:
--------------------------------------
Hallo Jonas,
I've hat a look at your enormous patch. Thanks for the effort you put in chain.
Since your patch contains lots of changes, there are lots of notes :) Would be
great if you could adjust the following:
* Chain:
** The JavaDoc of chain is missing its {{@return}} tag. Looks like a slip of
pen.
* Processing:
** we talked about the ABORTED state but decided to not add it for the moment
(see http://markmail.org/message/6anoz2qgkku43ocx and CHAIN-99)
** Several JavaDocs also contain references to {{Processing.ABORTED}} (for
example ChainExecutore, Command)
** JavaDocs should start with an upper case letter
** JavaDocs of the Processing states could be improved by reusing the JavaDocs
from the old constants from Command
* DispatchCommand:
** evaluate can stay like you refactored it. Preserving the old behavior is the
right thing to do.
* DispatchLookupCommand:
** do the same as for DispatchCommand, preserve behavior by checking for null
* DispatchLookupCommandTestCase:
** assert messages still refer to true/false as return values.
* LookupCommand:
** We may check for null results. I'm not sure about that. Commands must never
return null, and this has to be asserted at some point (probably in ChainBase).
* LookupCommandTestCase
** Same as DispatchLookupCommandTestCase, some assert messages stil refer to
true/false
* ChainBase:
** ChainBase definitively has to check for null results and should throw an
exception if a command returns null.
* TestContextTestCase
** This patch contains the changes CHAIN-94. Please make sure patches do only
contain what is necessary. This is a bit cumbersome when working on several
issues at once (maybe a git setup can help here?)
* Some JavaDocs look like:
{code:java}@return <code>CONTINUE</code> so that {@link Processing} will
continue}{code}
I think the solution you chose in ChainBase is better:
{code:java}@return {@link Processing#CONTINUE} if...{code}
TIA!
Benedikt
> Refactor command interface and base Implementations to enumeration to
> represent states
> --------------------------------------------------------------------------------------
>
> Key: CHAIN-98
> URL: https://issues.apache.org/jira/browse/CHAIN-98
> Project: Commons Chain
> Issue Type: Task
> Affects Versions: 2.0
> Reporter: Jonas Sprenger
> Assignee: Benedikt Ritter
> Fix For: 2.0
>
> Attachments: chain-98.patch
>
>
> Base implementations should return the constants CONTINUE_PROCESSING or
> PROCESSING_COMPLETE instead of returning true or false
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
