[
https://issues.apache.org/jira/browse/MATH-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753012#comment-13753012
]
Gilles edited comment on MATH-1026 at 8/29/13 8:27 AM:
-------------------------------------------------------
bq. I didn't think that re-factoring the test cases would be an issue for the ML
Small changes are more readily accepted; big changes leave questions about
whether we may have lost something in the process.
It way well be that your proposal leads to more flexibility and/or better
coverage. Those targets should be agreed on in advance to avoid lengthy
discussions: "If it ain't broken, why fix it?"
My view would have been
# Refactor the code
# If necessary (e.g. syntax changes as in this case), minimally refactor of the
tests
If all works, propose a more thorough refactoring of the tests, and after
agreement, open a JIRA task and start patching. Doing otherwise is more work
for everyone. :(
was (Author: erans):
bq. I didn't think that re-factoring the test cases would be an issue for
the ML
Small changes are more readily accepted; big changes leave questions about
whether we may have lost something in the process.
It way well be that your proposal leads to more flexibility and/or better
coverage. Those targets should be aggreed on in advance to avoid lengthy
discussions: "If it ain't broken, why fix it?"
My view would have been
# Free Refactor code
# Minimal (necessary) refactoring of the tests
If all works, propose emprovements (probably no just rmovr the "@Test" tag from
testSomething()
trest
> Separate Optimization Problem from Algorithm
> --------------------------------------------
>
> Key: MATH-1026
> URL: https://issues.apache.org/jira/browse/MATH-1026
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Evan Ward
> Attachments: opt.tar.gz
>
>
> See discussion on the mailing list starting with:
> http://www.mail-archive.com/[email protected]/msg39681.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
