[ 
https://issues.apache.org/jira/browse/MATH-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Neidhart updated MATH-1029:
----------------------------------

    Priority: Minor  (was: Major)
    
> Creating BigFraction objects is not consistent for negative/positive values
> ---------------------------------------------------------------------------
>
>                 Key: MATH-1029
>                 URL: https://issues.apache.org/jira/browse/MATH-1029
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Thomas Neidhart
>            Priority: Minor
>
> Creating a BigFraction object for large integer values will return different 
> results whether the argument is positive or negative:
> {noformat}
>   BigFraction f1 = new BigFraction(-1e10, 1000); -> will return a fraction 
> with a numerator of -1e10 and denominator of 1
>   BigFraction f2 = new BigFraction(1e10, 1000); -> will throw a 
> FractionConversionException
> {noformat}
> the problem is in the check for overflow, it is not done on the absolute 
> value of the argument, also it should be done only after the check if the 
> argument is actually an integer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to