[
https://issues.apache.org/jira/browse/COLLECTIONS-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769893#comment-13769893
]
Thomas Neidhart commented on COLLECTIONS-483:
---------------------------------------------
Thanks for your effort, just a few comments:
* you did not attach a patch, but rather a a complete rework of the existing
source tree, thus it is a bit difficult to see all the changes that have been
performed.
* after a quick look at the contents of the zip file, it seems that all the
interfaces and util classes have been moved to the respective subpackages, are
there any other substantial changes? Could you outline them to get a better
understanding.
* CompositeSet and CompositeCollection seem to have been moved to the list/map
package which seems odd, do you have a reason for this?
* you seem to have removed some classes, e.g. in the set package
> Cyclic dependencies among several packages.
> -------------------------------------------
>
> Key: COLLECTIONS-483
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-483
> Project: Commons Collections
> Issue Type: Improvement
> Affects Versions: 4.0, 4.0-alpha1
> Reporter: Brahim Djoudi
> Priority: Minor
> Attachments: c4.png, c4-refactored.png, c4-src.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Many packages have mutual dependency, directly or undirectly.
> These dependencies may be avoided just by moving some classes and interfaces
> within different packages.
> This refactoring breaks API compatibility but enhances the useability and the
> maintainability (hopefully) of the library. In addition, few issues in
> dynamic environments (like OSGi) less occur.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
