[
https://issues.apache.org/jira/browse/LANG-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779748#comment-13779748
]
Benedikt Ritter commented on LANG-804:
--------------------------------------
{code}
Benedikts-MacBook-Pro:lang bene$ svn ci -m "LANG-804 - Redundant check for zero
in HashCodeBuilder ctor. Patch provided by Allon Mureinik via github."
Sending src/changes/changes.xml
Sending
src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
Sending
src/test/java/org/apache/commons/lang3/builder/HashCodeBuilderTest.java
Transmitting file data ...
Committed revision 1526817.
{code}
Thanks for contributing!
> Redundant check for zero in HashCodeBuilder ctor
> ------------------------------------------------
>
> Key: LANG-804
> URL: https://issues.apache.org/jira/browse/LANG-804
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.builder.*
> Reporter: Sebb
> Priority: Minor
>
> The HashCodeBuilder(int, int) ctor checks both parameters for zero, as well
> as checking for an odd number.
> Zero is never odd, so the zero check could be eliminated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
