[ 
https://issues.apache.org/jira/browse/SCXML-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Woonsan Ko resolved SCXML-172.
------------------------------

    Resolution: Fixed

> Improve CustomActionTest not to depend on test method execution order
> ---------------------------------------------------------------------
>
>                 Key: SCXML-172
>                 URL: https://issues.apache.org/jira/browse/SCXML-172
>             Project: Commons SCXML
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Woonsan Ko
>            Assignee: Woonsan Ko
>            Priority: Minor
>             Fix For: 2.0
>
>
> The CustomActionTest#testCustomActionCallbacks() depends on method execution 
> order (@FixMethodOrder(MethodSorters.JVM)).
> However, the MethodSorters.JVM option may give inconsistent results in 
> different JVMs. [1]
> I think we'd better do the following:
> - Remove #testCustomActionCallbacks();
> - In each test method executing SCXML with Hello custom action, we can 
> compare the expected execution times on Hello custom action with the recorded 
> execution number in Hello class. (Each number can be reinitialized in 
> @Before.)
>   This would give more flexibility even when testing only each test method 
> (e.g, 'mvn test -Dtest=CustomActionTest#testSomething).
> [1] http://junit.czweb.org/apidocs/org/junit/runners/MethodSorters.html#JVM



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to