[
https://issues.apache.org/jira/browse/MATH-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798567#comment-13798567
]
Phil Steitz commented on MATH-1004:
-----------------------------------
Looks good, modulo one thing. I can't tell under what conditions exactly this
thing is going to throw DimensionMismatchException (which looks like the only
thing it can throw). In particular, it is not clear to me what this thing does
with a non-square matrix. Looks like it will try to get the pseudo-inverse.
Or does it throw? If the advertised exceptions are all that the method can
throw, great; if not it would be good to add whatever else it can throw. If it
does handle non-square matrices, we should say "(or pseudo-inverse)" and
ideally provide a reference to what exactly that means in the javadoc; if not
we should check argument and throw some kind of IAE (probably not propagate the
confusing DME). This doco / arg validation gap should probably be closed in
the decomposition solvers as well.
> Inversion of diagonal matrix
> ----------------------------
>
> Key: MATH-1004
> URL: https://issues.apache.org/jira/browse/MATH-1004
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Ajo Fod
> Assignee: Thomas Neidhart
> Priority: Minor
> Attachments: MATH-1004.patch, MATH-1004_updated.diff
>
>
> This should be a very easy feature to add and has many applications.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
