[
https://issues.apache.org/jira/browse/MATH-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Owen updated MATH-1045:
----------------------------
Attachment: MATH-1045.patch
On a little more research, it seems the thing to do is look at the ratio with
the largest eigenvalue. Attached is a new patch where your new test and my (2)
new tests all pass.
Comments welcome from linear algebra experts but I think this is at least as
principled as the existing code.
We could also let the user specify the zero threshold as in the QRDecomposition
class.
> EigenDecomposition.Solver should consider tiny values 0 for purposes of
> determining singularity
> -----------------------------------------------------------------------------------------------
>
> Key: MATH-1045
> URL: https://issues.apache.org/jira/browse/MATH-1045
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Sean Owen
> Priority: Minor
> Labels: eigenvalue, singular
> Attachments: MATH-1045.patch, MATH-1045.patch
>
>
> EigenDecomposition.Solver tests for singularity by comparing eigenvalues to 0
> for exact equality. Elsewhere in the class and in the code, of course, very
> small values are considered 0. This causes the solver to consider some
> singular matrices as non-singular.
> The patch here includes a test as well showing the behavior -- the matrix is
> clearly singular but isn't considered as such since one eigenvalue are ~1e-14
> rather than exactly 0.
> (What I am not sure of is whether we should really be evaluating the *norm*
> of the imaginary eigenvalues rather than real/imag components separately. But
> the javadoc says the solver only supports real eigenvalues anyhow, so it's
> kind of moot since imag=0 for all eigenvalues.)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
