[ 
https://issues.apache.org/jira/browse/IMAGING-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805496#comment-13805496
 ] 

Benedikt Ritter commented on IMAGING-120:
-----------------------------------------

I always try to see naming from an OO-design point of view. If you have an enum 
called ImageFormat that implements ImageFormatDescriptor then you're saying 
"every instance of ImageFormat _is a_ ImageFormatDescriptor". 

Damjan's suggestion seems to make more sense here. You have ImageFormats. One 
for example is BMP. And BMP _is a_ ImageFormat. sounds good to me.

> Extract an interface from ImageFormat
> -------------------------------------
>
>                 Key: IMAGING-120
>                 URL: https://issues.apache.org/jira/browse/IMAGING-120
>             Project: Commons Imaging
>          Issue Type: Improvement
>    Affects Versions: 0.97
>            Reporter: Matt Benson
>             Fix For: 1.0
>
>         Attachments: IMAGING-120.patch2.txt, IMAGING-120.patch.txt
>
>
> As discussed on the dev@commons ML, this would allow users to create custom 
> image formats while permitting the known image formats to be represented by 
> the {{ImageFormat enum}}.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to