Sebb created DBCP-404:
-------------------------

             Summary: Mutable fields should be private
                 Key: DBCP-404
                 URL: https://issues.apache.org/jira/browse/DBCP-404
             Project: Commons Dbcp
          Issue Type: Bug
            Reporter: Sebb


Non-private mutable fields make thread-safety harder.

Make all mutable fields private (or at worst package-protected), and use 
getters/setters for access if necessary.

This allows synchronisation to be easily added later if necessary, as well as 
potentially allowing validation of values.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to