[
https://issues.apache.org/jira/browse/COLLECTIONS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829253#comment-13829253
]
Thomas Neidhart commented on COLLECTIONS-471:
---------------------------------------------
Hi Radford,
I did review your patch and it looks pretty good.
Just a few remarks for your future contributions:
* you need to add an Apache license header, take a look at some other source
file
* the patch needs to be compliant to the coding style of the project
** the following formatter should work fine:
http://people.apache.org/~luc/Apache-commons.xml
** try checking your patch with checkstyle, the configuration for collections
can be found here: src/conf/checkstyle.xml
* a constructor BoundedIterator(Iterator, max) would be handy
* the remove method should be implemented too
The rest looks fine. I am usually not super strict about formatting, but the
more it is compliant the easier it is for the committer (= the faster it gets
integrated).
btw. we are currently in the process of releasing collections 4.0, so I can
commit your patches only after this is finished.
> Add a BoundedIterator which returns at most limit elements
> ----------------------------------------------------------
>
> Key: COLLECTIONS-471
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-471
> Project: Commons Collections
> Issue Type: New Feature
> Reporter: Thomas Neidhart
> Fix For: 4.x
>
> Attachments: BoundedIterator.java, BoundedIteratorTest.java
>
>
> It would be nice to have a decorator which bounds the number of elements
> returned by the decorated iterator.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
