[
https://issues.apache.org/jira/browse/POOL-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved POOL-246.
------------------------------
Resolution: Fixed
Fix Version/s: 2.1
Patch applied. Many thanks.
> [PATCH] Follow same pattern in ErodingKeyedObjectPool#toString as in other
> pool objects
> ---------------------------------------------------------------------------------------
>
> Key: POOL-246
> URL: https://issues.apache.org/jira/browse/POOL-246
> Project: Commons Pool
> Issue Type: Improvement
> Reporter: Bruno P. Kinoshita
> Priority: Trivial
> Labels: patch
> Fix For: 2.1
>
> Attachments: POOL-246.patch
>
>
> Hello!
> In ErodingObjectPool, the toString method outputs:
> ErodingObjectPool{factor=$FACTOR, pool=$POOL}
> And in ErodingPerKeyKeyedObjectPool it outputs:
> ErodingPerKeyKeyedObjectPool{factor=, keyedPool=$POOL}
> However, in ErodingKeyedObjectPool, the factor has a different prefix:
> ErodingKeyedObjectPool{erodingFactor=$FACTOR, keyedPool=$POOL}
> This proposed patch follows the same pattern as in the aforementioned pools
> and changes ErodingKeyedObjectPool#toString.
> Please, note that POOL-244 contains tests that may fail due to this change,
> so during the merge it may be good to take a look at
> TestPoolUtils#testErodingPoolKeyedObjectPoolDefaultFactor to avoid build
> errors.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
