[
https://issues.apache.org/jira/browse/LANG-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862369#comment-13862369
]
Benedikt Ritter commented on LANG-942:
--------------------------------------
{quote}
Right now, the easiest way to fix it would be removing the EDT and Eastern
Daylight Time from the tests. However, that would leave parts of the code
without test coverage (the code does different things for time zones that start
with - or +, time zones that start with GMT, and all the other time zones).
{quote}
The question here is, what is the correct result? This should be expressed in
the test and the implementation has to be changed to conform to the test. What
I don't unterstand is what exactly Eastern Daylight Time is. Is it a time zone
by itself? Or is it a grouping of time zones? It looks like IET and US/Michigan
have different times, so the question appears what the expected result is, when
parsing something like:
{code}
"2003-07-10T16:33:20.000 Eastern Daylight Time"
{code}
{quote}
Therefore they cannot be used as keys in a map anyway.
{quote}
Yes, but the problem is: how do we map "Eastern Daylight Time" in a string
representation of a Date, if Eastern Daylight Time can mean several time zones.
I'd say we should do the same like {{java.util.SimpleDateFromat}} does in this
case.
> Test failure in FastDateParserTest and FastDateFormat_ParserTest when
> building with JDK8
> ----------------------------------------------------------------------------------------
>
> Key: LANG-942
> URL: https://issues.apache.org/jira/browse/LANG-942
> Project: Commons Lang
> Issue Type: Sub-task
> Components: lang.time.*
> Affects Versions: 3.2
> Environment: JDK8
> Reporter: Benedikt Ritter
> Fix For: 3.2.1
>
>
> The following failure is thrown when using JDK 8:
> {code}
> -------------------------------------------------------------------------------
> Test set: org.apache.commons.lang3.time.FastDateFormat_ParserTest
> -------------------------------------------------------------------------------
> Tests run: 29, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.315 sec
> <<< FAILURE! - in org.apache.commons.lang3.time.FastDateFormat_ParserTest
> testParseZone(org.apache.commons.lang3.time.FastDateFormat_ParserTest) Time
> elapsed: 0.005 sec <<< FAILURE!
> java.lang.AssertionError: expected:<Thu Jul 10 22:33:20 CEST 2003> but
> was:<Thu Jul 10 23:33:20 CEST 2003>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.commons.lang3.time.FastDateParserTest.testParseZone(FastDateParserTest.java:119)
> [...]
> {code}
> It is caused by the following assertion in FastDateParserTest (from which
> FastDateFormat_ParserTest inherits):
> {code:java}
> assertEquals(cal.getTime(), fdf.parse("2003-07-10T16:33:20.000 Eastern
> Daylight Time"));
> {code}
> {{FastDateParserTest}} fails with the same error.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
