[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867903#comment-13867903
 ] 

Rob McDougall commented on FILEUPLOAD-137:
------------------------------------------

If the constructor MultipartStream(InputStream, byte[], int, ProgressNotifier) 
is public, is there any reason not to make the convenience function 
MultipartStream(InputStream input, byte[] boundary, ProgressNotifier pNotifier) 
public as well?  They are both mentioned in the comments for the deprecated 
constructors but only one is actually public.

> MultipartStream public API broken
> ---------------------------------
>
>                 Key: FILEUPLOAD-137
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-137
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Mark Sinke
>            Assignee: Jochen Wiedmann
>             Fix For: 1.2.1, 1.3.1
>
>
> In commons-transaction 1.2 the MultipartStream class has 2 public 
> constructors. Both are deprecated; however their implementation delegates to 
> non-visible (package-private) constructors. There are two issues here:
> 1. the deprecated, delegating constructors use a null pointer for the 
> progress notifier, which in turn yield a NullPointerException when you try to 
> use them
> 2. the non-deprecated constructors are not visible.
> Hence, I cannot really upgrade from 1.0 to 1.2.
> Thanks,
> Mark.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to