[
https://issues.apache.org/jira/browse/LANG-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869024#comment-13869024
]
Benedikt Ritter commented on LANG-613:
--------------------------------------
Hello Ben,
I've reviewed your patch. Here are my findings:
* You're using tabs to indent your code. Please only use spaces, since the
representation of tabs depends on your editor
* The tests are missing the {{@Test}} annotation
* The new files are missing the Apache License header
usually I would fix this myself and apply the patch, but the missing AL header
is a problem. You either have to file an [Individual Contributor License
Agreement|http://www.apache.org/licenses/] or reapply the patch with AL headers
included. Sorry for the hassle but this is necessary to make sure we don't run
into trouble regarding intellectual property.
Thanks for contributing,
Benedikt
> ConstructorUtils.getAccessibleConstructor() Does Not Check the Accessibility
> of Enclosing Classes
> -------------------------------------------------------------------------------------------------
>
> Key: LANG-613
> URL: https://issues.apache.org/jira/browse/LANG-613
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
> Affects Versions: 3.0
> Reporter: David M. Sledge
> Assignee: Benedikt Ritter
> Priority: Minor
> Labels: patch
> Fix For: 3.3, Review Patch
>
> Attachments:
> LANG-613_Recursive_visibility_check_up_the_enclosing_tree.patch
>
>
> ConstructorUtils.getAccessibleConstructor() checks if the declaring class is
> public but not whether it's a top-level class or an enclosed one.
> Consequently, with enclosed declaring classes, the method does not check if
> the enclosing class is public, or it's enclosing class, or it's enclosing
> class, etc...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
