[
https://issues.apache.org/jira/browse/DBCP-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DBCP-364.
------------------------------
Resolution: Fixed
Thanks for the report and sorry this has taken a while to fix.
This is an API change so it will be included in 2.0 onwards only.
> BasicDataSourceFactory#createDataSource return signature should be
> BasicDataSourceFactory so that caller can invoke methods not declared in
> DataSource (e.g., close())
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DBCP-364
> URL: https://issues.apache.org/jira/browse/DBCP-364
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: ori
> Priority: Trivial
> Fix For: 2.0
>
>
> BasicDataSourceFactory#createDataSource currently returns a DataSource
> instance.
> It should a return type of BasicDataSourceFactory. Otherwise the caller has
> to cast it to invoke close (and other methods specific to the implementation).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)