[
https://issues.apache.org/jira/browse/FILEUPLOAD-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb updated FILEUPLOAD-249:
----------------------------
Summary: DiskFileItem lazy instantiation of dfos field is not useful (was:
DiskFileItem lazy instantiation or dfos field is not useful)
> DiskFileItem lazy instantiation of dfos field is not useful
> -----------------------------------------------------------
>
> Key: FILEUPLOAD-249
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-249
> Project: Commons FileUpload
> Issue Type: Bug
> Reporter: Sebb
>
> AFAICT, the lazy instantiation of the dfos field is not very useful, as many
> methods fail with NPE unless it has been defined.
> There is very little that can be done with the instance until the dfos field
> has been created - even toString() fails.
> In which case, why not create the field at construction time?
> It can then be made final.
> As a consequence, tempFile would also need to be created by the ctor.
> It looks as though dfosFile could then also be made final.
> [These fields are all private so the API would not change.]
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
