[
https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907169#comment-13907169
]
Sebb commented on NET-525:
--------------------------
Thanks, that looks better.
A few minor issues, which I can deal with (no need to create another patch):
+ tabs are banned
+ all conditional statements must have blocks
+ some missing @Override tags
Also, we don't allow @author tags in Javadoc.
They quickly get out of date as code is updated.
Instead we add contributors to the Maven pom and/or add them to the changes
list.
Would it be OK for me to do that with your contributions?
> Added missing set methods on NTP class and interface
> ----------------------------------------------------
>
> Key: NET-525
> URL: https://issues.apache.org/jira/browse/NET-525
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 3.3
> Reporter: jason mathews
> Labels: ntp
> Attachments: diff.patch.txt
>
>
> I was the original contributor of the NTP implementation and have recently
> cleaned the source and submitting the relevant changes.
> Here is the summary of changes:
> src/main/java/org/apache/commons/net/ntp/TimeInfo.java
> -Added missing equals() and hashCode() methods
> -Added new method: getAddress()
> src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
> -Added missing methods: setPrecision(), setRootDelay(), and
> setRootDispersion()
> src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
> -Added missing equals() and hashCode() methods
> -Added missing set methods: setRootDelay(), setRootDispersion(),
> -Added validation check to setDatagramPacket()
> Added additional tests:
> -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
> -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
> See attached patch.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
