[jira] [Resolved] (NET-525) Added missing set methods on NTP class and interface

[Sebb (JIRA)]

     [ 
https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-525.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.4

Thanks very much; applied:

URL: http://svn.apache.org/r1570303
Log:
NET-525 Added missing set methods on NTP class and interface

Added:
    
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
   (with props)
    
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
   (with props)
Modified:
    commons/proper/net/trunk/pom.xml
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/examples/ntp/NTPClient.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NTPUDPClient.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpUtils.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/TimeInfo.java
    
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
    
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TimeStampTest.java
    
commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.jav

> Added missing set methods on NTP class and interface
> ----------------------------------------------------
>
>                 Key: NET-525
>                 URL: https://issues.apache.org/jira/browse/NET-525
>             Project: Commons Net
>          Issue Type: Improvement
>    Affects Versions: 3.3
>            Reporter: jason mathews
>              Labels: ntp
>             Fix For: 3.4
>
>         Attachments: diff.patch.txt
>
>
> I was the original contributor of the NTP implementation and have recently 
> cleaned the source and submitting the relevant changes.
> Here is the summary of changes:
> src/main/java/org/apache/commons/net/ntp/TimeInfo.java
> -Added missing equals() and hashCode() methods
> -Added new method: getAddress() 
> src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
> -Added missing methods: setPrecision(), setRootDelay(), and 
> setRootDispersion()
> src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
> -Added missing equals() and hashCode() methods
> -Added missing set methods: setRootDelay(), setRootDispersion(), 
> -Added validation check to setDatagramPacket()
> Added additional tests:
> -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
> -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
> See attached patch.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)