[
https://issues.apache.org/jira/browse/CODEC-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory resolved CODEC-181.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.10
Assignee: Gary Gregory
Applied patch and then restored PAD and ctor to maintain binary compatibility.
Thank you!
Is your QRCode code something that would fit in Commons Codec?
{noformat}
commit -m "<action dev="ggregory" type="add" issue="CODEC-181" due-to="Ivan
Martinez-Ortiz">Make possible to provide padding byte to BaseNCodec in
constructor</action>" (6 paths specified)
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/changes/changes.xml
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/binary/Base32.java
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/binary/Base64.java
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/test/java/org/apache/commons/codec/binary/Base32Test.java
Sending
C:/vcs/svn/apache/commons/trunks-proper/codec/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java
Transmitting file data ...
Committed revision 1571406.
{noformat}
> Make possible to provide padding byte to BaseNCodec in constructor
> ------------------------------------------------------------------
>
> Key: CODEC-181
> URL: https://issues.apache.org/jira/browse/CODEC-181
> Project: Commons Codec
> Issue Type: Improvement
> Affects Versions: 1.9, 1.10
> Reporter: Ivan Martinez-Ortiz
> Assignee: Gary Gregory
> Priority: Minor
> Fix For: 1.10
>
> Attachments: BaseNCodec_new_constructor.patch,
> patch_with_test_case.diff
>
>
> Hi,
> I'm developing an application that generates QRCodes, so the user does not
> need to type a HMAC value. QRCodes [1] supports different encoding formats,
> in particular the alpha numeric format is almost compatible with the Base32
> (the only problematic character is the '=' character).
> I created an almost exact copy of Base32 class in order to change the padding
> byte, however the BaseNCodec#PAD byte is final and not settable in the class
> constructor.
> I already tested this approach and I can provide a patch to support this new
> feature.
> [1] http://en.wikipedia.org/wiki/QR_code
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
