[
https://issues.apache.org/jira/browse/COLLECTIONS-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988630#comment-13988630
]
Sebb commented on COLLECTIONS-521:
----------------------------------
Thanks for the patch. Looks good to me, but ideally there should first be a
test case that exposes the bug.
If key2 == null then presumably the current code will throw NPE.
> Typo in MultiMapKey's isEqualKey(entry, key1, key2)
> ---------------------------------------------------
>
> Key: COLLECTIONS-521
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-521
> Project: Commons Collections
> Issue Type: Bug
> Reporter: Maxime Nay
>
> I believe there is a typo line 252 in MultiKeyMap.
> return
> multi.size() == 2 &&
> (key1 == multi.getKey(0) || key1 != null &&
> key1.equals(multi.getKey(0))) &&
> (key2 == multi.getKey(1) || key1 != null &&
> key2.equals(multi.getKey(1)));
> should be:
> return
> multi.size() == 2 &&
> (key1 == multi.getKey(0) || key1 != null &&
> key1.equals(multi.getKey(0))) &&
> (key2 == multi.getKey(1) || key2 != null &&
> key2.equals(multi.getKey(1)));
--
This message was sent by Atlassian JIRA
(v6.2#6252)
