[
https://issues.apache.org/jira/browse/IO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukáš Petrovický updated IO-444:
--------------------------------
Description:
I have provided a pull request that converts Tailer to
java.util.concurrent.ScheduledExecutorService:
https://github.com/apache/commons-io/pull/2
This has multiple benefits:
- it provides periodic runs of the read operations without needing to invoke
Thread.sleep().
- it removes any looping from the run() method, making for cleaner code.
- generally brings Tailer closer to what modern Java looks like.
This is a first step towards Tailer which supports easier monitoring. When (if)
this is merged, I intend to submit another pull request, where the
TailerListener will be extended with the begin() and commit() methods -
executed when the tailer's currently scheduled instance starts/stops reading.
This will allow users to process messages in bursts.
No public API changes have been made. All tests are passing without
modifications. I kindly ask you to merge it.
was:
I have provided a pull request that converts Tailer to
java.util.concurrent.ScheduledExecutorService:
https://github.com/apache/commons-io/pull/2
This has multiple benefits:
- it provides periodic runs of the read operations without needing to invoke
Thread.sleep().
- it removes any looping from the run() method, making for cleaner code.
- generally brings Tailer closer to what modern Java looks like.
No public API changes have been made. All tests are passing without
modifications. I kindly ask you to merge it.
> Convert Tailer to ScheduledExecutorService
> ------------------------------------------
>
> Key: IO-444
> URL: https://issues.apache.org/jira/browse/IO-444
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.5
> Reporter: Lukáš Petrovický
> Priority: Minor
>
> I have provided a pull request that converts Tailer to
> java.util.concurrent.ScheduledExecutorService:
> https://github.com/apache/commons-io/pull/2
> This has multiple benefits:
> - it provides periodic runs of the read operations without needing to invoke
> Thread.sleep().
> - it removes any looping from the run() method, making for cleaner code.
> - generally brings Tailer closer to what modern Java looks like.
> This is a first step towards Tailer which supports easier monitoring. When
> (if) this is merged, I intend to submit another pull request, where the
> TailerListener will be extended with the begin() and commit() methods -
> executed when the tailer's currently scheduled instance starts/stops reading.
> This will allow users to process messages in bursts.
> No public API changes have been made. All tests are passing without
> modifications. I kindly ask you to merge it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
