[
https://issues.apache.org/jira/browse/DBCP-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008790#comment-14008790
]
Bjorn Vidar Remme commented on DBCP-420:
----------------------------------------
Nice! This tiny patch was the final detail in our transition from dbcp to
dbcp2. The nasty threading problem we had with the old dbcp is gone, dbcp2
looks really solid. Impressive resolve time on this issue. Thanks!
> InstanceKeyDataSource discards native SQLException when given password does
> not match password used to create the connection
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: DBCP-420
> URL: https://issues.apache.org/jira/browse/DBCP-420
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: Bjorn Vidar Remme
> Fix For: 2.0.2
>
> Attachments: dbcp_420_patch.txt
>
>
> The throw in InstanceKeyDataSource at line 936 does not pass on the native
> SQL exception from the connection test:
> {code}
> } catch (SQLException ex) {
> // Password has not changed, so refuse client, but return
> connection to the pool
> closeDueToException(info);
> throw new SQLException("Given password did not match password
> used"
> + " to create the PooledConnection.");
> }
> {code}
> It would be great if this throw could include the cause exception:
> {code}
> throw new SQLException("Given password did not match password
> used"
> + " to create the PooledConnection.",
> ex);
> {code}
> as we have code that detects login related SQLExceptions and takes actions on
> them.
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
