[ 
https://issues.apache.org/jira/browse/LANG-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015777#comment-14015777
 ] 

Benedikt Ritter commented on LANG-1017:
---------------------------------------

Fixed in revision 1599322. I've also added test cases for the new example. 
Thanks for the pointer!

> Use non-ASCII digits in Javadoc examples for StringUtils.isNumeric
> ------------------------------------------------------------------
>
>                 Key: LANG-1017
>                 URL: https://issues.apache.org/jira/browse/LANG-1017
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.3.2
>            Reporter: Christoph Schneegans
>            Assignee: Benedikt Ritter
>            Priority: Trivial
>             Fix For: 3.4
>
>
> The Javadoc comment for the method 
> org.apache.commons.lang3.StringUtils.isNumeric(CharSequence) contains a 
> single "true" case, namely
>   \* StringUtils.isNumeric("123")  = true
> Hence, one might wrongly assume that this method is suitable to check whether 
> a string consists only of ASCII digits (U+0030..U+0039).
> Consider providing another "true" case, e.g. using Devanagari digits:
>   \* StringUtils.isNumeric("१२३")  = true
>   \* StringUtils.isNumeric("&\#x967;&\#x968;&\#x969;") = true



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to