[
https://issues.apache.org/jira/browse/CODEC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027502#comment-14027502
]
Thomas Neidhart commented on CODEC-187:
---------------------------------------
The problem that you have found is related to some of the rules file
(gen_approx_any.txt):
instead of
{noformat}
"A" "" "[^aeiouAEBFIOU]e" "(a|o|Y[$german]|D[$english])" // "plane"
{noformat}
it should be
{noformat}
"A" "" "[^aeiouAEBFIOU]e" "(a|o|Y[german]|D[english])" // "plane"
{noformat}
There are other occurrences of the same error in this file, maybe in others too.
The more serious problem is now that it looks like a 1:1 translation of the
original php code from the authors of the algorithm which is released as GPL
code. Now, I am not sure if we received permission to include the rules in
codec under the Apache license as otherwise we have a real problem here.
> Beider Morse Phonetic Matching producing incorrect tokens
> ---------------------------------------------------------
>
> Key: CODEC-187
> URL: https://issues.apache.org/jira/browse/CODEC-187
> Project: Commons Codec
> Issue Type: Bug
> Affects Versions: 1.9
> Reporter: michael tobias
> Priority: Minor
>
> I believe the Beider Morse Phonetic Matching algorithm was added in Commons
> Codec 1.6
> The BMPM algorithm is an EVOLVING algorithm that is currently on version 3.02
> though it had been static since version 3.01 dated 19 Dec 2011 (it was first
> available as opensource as version 1.00 on 6 May 2009).
> I can see nothing in the Commons Codec Docs to say which version of BMPM was
> implemented so I am not sure if the problem with the algorithm as coded in
> the Codec is simply an old version or whether there are more basic problems
> with the implementation.
> How do I determine the version of the algorithm that was implemented in the
> Commons Codec?
> How do we ensure that the algorithm is updated if/when the BMPM algorithm
> changes?
> How do we ensure that the algorithm as coded in the Commons Codec is accurate
> and working as expected?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
