[
https://issues.apache.org/jira/browse/COMPRESS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032472#comment-14032472
]
Matthias Stevens commented on COMPRESS-263:
-------------------------------------------
Thanks for committing the patch!
Oops, I didn't mean to include the changes to the POM in my patch. Sorry, I'm
quite new to all of this.
You're probably right about the isZlibHeaderPresent name, I did consider a few
alternatives, but they all were either reading (e.g. "expectZlibHeader") or
writing (e.g. "putZlibHeader") specific. Your "withZlibtHeader" sounds good to
me though, go for it ;-).
I think auto-detection of a headerless zlib stream is not possible, but perhaps
it is possible with the zlib header. I'll look into that.
As for your other remarks: I'll look into providing docs, but I might not have
time the coming days/weeks. I'll also look at the byte counting stuff. Can you
perhaps point me to an example in Compress were this is used the right way?
Thanks!
> Add DEFLATE support
> -------------------
>
> Key: COMPRESS-263
> URL: https://issues.apache.org/jira/browse/COMPRESS-263
> Project: Commons Compress
> Issue Type: New Feature
> Components: Compressors
> Reporter: Matthias Stevens
> Labels: features
> Fix For: 1.9
>
> Attachments: COMPRESS-263_DeflateSupport.patch,
> COMPRESS-263_DeflateSupport_v1.1.patch, bla.tar.deflate, bla.tar.deflatez
>
>
> GZIP is not a compression algorithm "as such". The de facto (and currently
> the only supported) compression algorithm it uses is DEFLATE.
> GZIP adds a header of minimum 10 bytes and a footer of 8 bytes to a
> "deflated" data stream. Find out more here:
> http://en.wikipedia.org/wiki/Gzip#File_format
> I have no problem with the current GZIP support, but it would be nice if
> CommonsCompress would also have compression and decompression support for
> "raw" DEFLATE streams and DEFLATE streams with the zlib header.
> Similarly to the GZIP support in CommonsCompress these functionality can be
> implemented very easily using the standard java.util.zip package, as done in
> the provided patch.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
