[
https://issues.apache.org/jira/browse/LANG-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050941#comment-14050941
]
Sebb commented on LANG-1022:
----------------------------
So what should the code do if the value is out of range?
I would expect it to throw IllegalArgumentException ...
> NumericEntityUnescaper.translate throws an IllegalArgumentException if
> entityValue > MAX_CODE_POINT
> ---------------------------------------------------------------------------------------------------
>
> Key: LANG-1022
> URL: https://issues.apache.org/jira/browse/LANG-1022
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.text.translate.*
> Reporter: Miquel
> Priority: Minor
>
> We found that using the function StringEscapeUtils.unescapeHtml4 crashes if
> the argument is "�" and throws an IllegalArgumentException.
> This happens because internally it calls the function
> NumericEntityUnescaper.translate and doesn't check if the value is bigger
> than 0x10FFFF (MAX_CODE_POINT) that is a check inside Character.toChar.
> Maybe we need to check that the entity value is less than Char.MAX_CODE_POINT.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
