[
https://issues.apache.org/jira/browse/MATH-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066892#comment-14066892
]
Gilles commented on MATH-1139:
------------------------------
Thanks.
The code looks quite clean, but I didn't find the unit tests.
Also, it looked like "tab" characters are used for indentation (whereas should
be 4 "space" characters for Commons Math).
Could you please attach the Java files to this page.
\[Until we've all moved to using "git"...\]
For the "logistic distribution", I suggest that the proposed implementation
reuses the [function defined in package
"o.a.c.m.analysis.function"|http://commons.apache.org/proper/commons-math/apidocs/org/apache/commons/math3/analysis/function/Logistic.html].
The fields could be declared "final".
> Implement Gumbel, Laplace, Logistic and Nakagami distributions
> --------------------------------------------------------------
>
> Key: MATH-1139
> URL: https://issues.apache.org/jira/browse/MATH-1139
> Project: Commons Math
> Issue Type: Wish
> Reporter: Alexey Volkov
> Priority: Minor
>
> Implement distributions listed below:
> * [Gumbel|http://en.wikipedia.org/wiki/Gumbel_distribution] distribution
> * [Laplace|http://en.wikipedia.org/wiki/Laplace_distribution] distribution
> * [Logistic|http://en.wikipedia.org/wiki/Logistic_distribution] distribution
> * [Nakagami|http://en.wikipedia.org/wiki/Nakagami_distribution] distribution
--
This message was sent by Atlassian JIRA
(v6.2#6252)
