[ 
https://issues.apache.org/jira/browse/IO-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088883#comment-14088883
 ] 

Benedikt Ritter commented on IO-380:
------------------------------------

I agree that closing the InputStream is the caller's job (who probably created 
the stream).

> FileUtils.copyInputStreamToFile should document it closes the input source
> --------------------------------------------------------------------------
>
>                 Key: IO-380
>                 URL: https://issues.apache.org/jira/browse/IO-380
>             Project: Commons IO
>          Issue Type: Improvement
>    Affects Versions: 2.4
>         Environment: JDK 7, OSX 10.8.3 (doesn't matter)
>            Reporter: Claudio Nieder
>            Priority: Trivial
>             Fix For: 2.5
>
>
> It would be nice to extend the parameter description
> @param source  the <code>InputStream</code> to copy bytes from, must not be 
> {@code null}
> to read:
> @param source  the <code>InputStream</code> to copy bytes from, must not be 
> {@code null}, will be closed
> so that one is aware it cannot be used e.g. on ZipInputStream which require 
> the stream to still be open for executing zip.getNextEntry.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to