[
https://issues.apache.org/jira/browse/POOL-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100684#comment-14100684
]
Michael Osipov commented on POOL-268:
-------------------------------------
Conditions must be documented in Javadoc, not thrown. Runtime exceptions aren't
recoverable so there is no point in throwing them explicitly.
> Remove throws <RuntimeException> from all method signatures
> -----------------------------------------------------------
>
> Key: POOL-268
> URL: https://issues.apache.org/jira/browse/POOL-268
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Michael Osipov
>
> Unfortunately, many signatures carry a {{throws <RuntimeException>}} like
> {{IllegalStateException}}, etc. This is incorrect. A runtime exception never
> appears in the signature but only in the Javadocs because runtime exception
> indicate a programming error.
> This violates against Java programming rules and Joshua Bloch's Effective
> Java.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
