[ 
https://issues.apache.org/jira/browse/MATH-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104119#comment-14104119
 ] 

Guillaume Marceau commented on MATH-1148:
-----------------------------------------

Inversely, points in a column that should be dropped will sometimes be kept 
instead if `includeCollinearPoints = true`.

This input: 
{code}
[{0; -29.959696875}, {0; -31.621809375}, {0; -28.435696875}, {0; 
-33.145809375}, {3.048; -33.145809375}, {3.048; -31.621809375}, {3.048; 
-29.959696875}, {4.572; -33.145809375}, {4.572; -28.435696875}]
{code}
computes the this upper hull:
{code}
[{4.572; -28.435696875}, {0; -28.435696875}, {0; -31.621809375}, {0; 
-29.959696875}]
{code}
which retrogrades at the end.


> MonotoneChain handling of collinear points drops low points in a near-column
> ----------------------------------------------------------------------------
>
>                 Key: MATH-1148
>                 URL: https://issues.apache.org/jira/browse/MATH-1148
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.3
>            Reporter: Guillaume Marceau
>
> This code
> {code}
> val points = List(
>   new Vector2D(
>     16.078200000000184,
>     -36.52519999989808
>   ),
>   new Vector2D(
>     19.164300000000186,
>     -36.52519999989808
>   ),
>   new Vector2D(
>     19.1643,
>     -25.28136477910407
>   ),
>   new Vector2D(
>     19.1643,
>     -17.678400000004157
>   )
> )
> new hull.MonotoneChain().generate(points.asJava)
> {code}
> results in the exception:
> {code}
> org.apache.commons.math3.exception.ConvergenceException: illegal state: 
> convergence failed
>       at 
> org.apache.commons.math3.geometry.euclidean.twod.hull.AbstractConvexHullGenerator2D.generate(AbstractConvexHullGenerator2D.java:106)
>       at 
> org.apache.commons.math3.geometry.euclidean.twod.hull.MonotoneChain.generate(MonotoneChain.java:50)
>       at .<init>(<console>:13)
>       at .<clinit>(<console>)
>       at .<init>(<console>:11)
>       at .<clinit>(<console>)
>       at $print(<console>)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>       at java.lang.reflect.Method.invoke(Method.java:597)
>       at scala.tools.nsc.interpreter.IMain$ReadEvalPrint.call(IMain.scala:704)
>       at 
> scala.tools.nsc.interpreter.IMain$Request$$anonfun$14.apply(IMain.scala:920)
>       at 
> scala.tools.nsc.interpreter.Line$$anonfun$1.apply$mcV$sp(Line.scala:43)
>       at scala.tools.nsc.io.package$$anon$2.run(package.scala:25)
>       at java.lang.Thread.run(Thread.java:662)
> {code}
> This will be tricky to fix. Not only is the point (19.164300000000186, 
> -36.52519999989808) is being dropped incorrectly, but any point dropped in 
> one hull risks creating a kink when combined with the other hull.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to