[
https://issues.apache.org/jira/browse/DBUTILS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165395#comment-14165395
]
Benedikt Ritter commented on DBUTILS-120:
-----------------------------------------
Hello [~Alex K.],
I took some time to review your patch. It looks promising, but there are a few
things I'd like to discuss:
* queryNamePattern and linesToSkip don't need to be recomputed each time. It is
sufficient to declare them as static fields like to other patterns
* why is the resultMap initialized with a capacity of 32?
* why do you throw an InputMismatchException (and not for example
IllegalArgumentException)
* UnsupportedEncodingException does not have to be declared, since the more
general IOException is already declared
* please only use spaces to indent code (not tabs)
br,
Benedikt
> Add loading from SQL file to QueryLoader
> ----------------------------------------
>
> Key: DBUTILS-120
> URL: https://issues.apache.org/jira/browse/DBUTILS-120
> Project: Commons DbUtils
> Issue Type: Improvement
> Reporter: Aleksei Kovura
> Assignee: Benedikt Ritter
> Labels: patch
> Attachments: dbutilsQueryLoader.diff, dbutilsQueryLoader_2.diff
>
>
> See comments for proposed formats.
> Initially it was this:
> ---queryName1:
> SELECT * FROM "APP"."TABLE1";
> ---queryName2:
> SELECT column1, column2 FROM "APP"."TABLE2" WHERE column1=?;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
